Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs extended] Keyboard navigation top-down arrows not moving tab focus - DPO Consulting #7719

Closed
shixiedesign opened this issue Nov 22, 2021 · 2 comments · Fixed by #8243
Closed

[Tabs extended] Keyboard navigation top-down arrows not moving tab focus - DPO Consulting #7719

shixiedesign opened this issue Nov 22, 2021 · 2 comments · Fixed by #8243
Assignees
@emyarod @andy-blum
Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Nov 22, 2021 •
edited by proeung
Loading

Engineering info:

When tabs extended changes layout orientation from horizontal to vertical, we expect the keyboard control to change to arrow up / down keys. Currently tabs extended vertical can only be controlled via arrow left / right keys.

Nov-21-2021 20-46-47.gif
@shixiedesign shixiedesign added accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work labels Nov 22, 2021
@shixiedesign shixiedesign mentioned this issue Nov 22, 2021
Closed
3 tasks
@shixiedesign shixiedesign changed the title [Tabs extended] keyboard behavior bug [Tabs extended] tooltip & keyboard behavior bug Nov 22, 2021
@RobertaJHahn RobertaJHahn added the severity 4 Affects minor functionality, no workaround needed label Nov 23, 2021
@kennylam
Copy link
Member

@shixiedesign Which environment are you seeing this behavior?

@shixiedesign shixiedesign added the package: web components Work necessary for the IBM.com Library web components package label Nov 23, 2021
@shixiedesign
Copy link
Contributor Author

Hey @kennylam on Web components canary, on Chrome.

Actually Safari is not displaying any focus state on the Tabs themselves. I can make another ticket if that's needed.

@shixiedesign shixiedesign changed the title [Tabs extended] tooltip & keyboard behavior bug [Tabs extended] Keyboard navigation top-down arrows not moving tab focus Dec 6, 2021
@jeffchew jeffchew added follow-up: innovation team owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants and removed follow-up: innovation team labels Feb 7, 2022
@proeung proeung changed the title [Tabs extended] Keyboard navigation top-down arrows not moving tab focus [Tabs extended] Keyboard navigation top-down arrows not moving tab focus - DPO Consulting Feb 7, 2022
@andy-blum andy-blum mentioned this issue Feb 9, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #8243 Feb 11, 2022
kodiakhq bot pushed a commit that referenced this issue Feb 11, 2022
@andy-blum
fix(tabs-extended): add vertical arrow key support (#8243)
0b17c94 
### Related Ticket(s)

{{Provide url(s) to the related ticket(s) that this pull request addresses}}

fixes #7719

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

Adds arrow-up and arrow-down navigation to the tabs-extended component

### Changelog

**Changed**

- Adds arrow-up and arrow-down navigation to the tabs-extended component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

@andy-blum andy-blum

Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs-extended): add vertical arrow key support andy-blum/carbon-for-ibm-dotcom
6 participants
@kennylam @jeffchew @emyarod @shixiedesign @andy-blum @RobertaJHahn