Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card] Allow text link on Card in all situations #7631

Closed
2 tasks done
GeoPei opened this issue Nov 9, 2021 · 3 comments
Closed
2 tasks done

[Card] Allow text link on Card in all situations #7631

GeoPei opened this issue Nov 9, 2021 · 3 comments

Comments

@GeoPei
Copy link

GeoPei commented Nov 9, 2021

The problem

Hi team

My client hopes to add link text to the link of each card in the card group component, but we found that there is no component that can be used, could you please help to update the component?

Thank you.

The solution

we want to add the link text on the card group component, now we just add title, description, link.

Application/website

https://www.ibm.com/strategic-partnerships/fr-fr/ois/

Business priority

High Priority = pressing release

What time frame would this ideally be needed by (if applicable)

No response

Examples

No response

Code of Conduct

@annawen1
Copy link
Member

annawen1 commented Nov 9, 2021

Hi @GeoPei! The design team reached out to your original question in slack, I've copied @shixiedesign's response here:

the basic card (not in group) allows CTA text. When used in a card group without image like this, we tried to make sure the cards don’t become overly text heavy. If you look at card in image above, there are actually heading, body copy, and (not shown is) eyebrow text, 3 places to give the users an idea what the card should do.
If you think you really need the additional CTA text, please share your use case and we can take a look! The system is open to growing based on adopter needs.

Closing this ticket based on the comment from @shixiedesign, but if you feel you have a use case feel free to reopen this ticket and add details.

@annawen1 annawen1 closed this as completed Nov 9, 2021
@jeffchew jeffchew added the dev Needs some dev work label Nov 9, 2021
@shixiedesign
Copy link
Contributor

Thanks @annawen1 for pulling in my response from Slack and @GeoPei, we have been discussing this internally again, and we realize what you @GeoPei are trying to do (heading + copy + CTA text) is necessary for UX, esp. when people skip reading the copy, and people often do. We were more worried about 4 types of texts (heading + copy + CTA text + eyebrow).

So considering this requested feature makes a good design, I think we will proceed to allow CTA text, so reopening this issue. I will capture the recommendation of using only up to 3 types of text in the usage guidance webpage for Cards.

@shixiedesign shixiedesign reopened this Nov 10, 2021
@RobertaJHahn RobertaJHahn removed this from the Sprint 21-23 milestone Nov 10, 2021
@RobertaJHahn RobertaJHahn added adopter support package: react Work necessary for the Carbon for IBM.com react components package labels Nov 16, 2021
@RobertaJHahn
Copy link

RobertaJHahn commented Nov 16, 2021

convert to an epic, func specs update, WC and pure React dev, QA and website, no e2e test update

schedule the React dev before WC

@RobertaJHahn RobertaJHahn added package: web components Work necessary for the IBM.com Library web components package priority: medium design Applied to all issues assigned to the design team members. Filter used in planning meetings epic labels Nov 16, 2021
@RobertaJHahn RobertaJHahn changed the title add the link text on the Card group [Card] Allow text link on Card in all situations Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants