Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] CTA text doesn't wrap #6935

Closed
shixiedesign opened this issue Aug 20, 2021 · 1 comment
Closed

[Card] CTA text doesn't wrap #6935

shixiedesign opened this issue Aug 20, 2021 · 1 comment
Assignees
@BrunnoM7
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed
Milestone
Sprint 21-22

Comments

@shixiedesign
Copy link
Contributor

Current in Canary

When CTA text is long, the text doesn't wrap, instead goes outside the card:

image.png

Expecting

image.png
@shixiedesign shixiedesign added bug Something isn't working dev Needs some dev work labels Aug 20, 2021
@RobertaJHahn RobertaJHahn added the severity 4 Affects minor functionality, no workaround needed label Aug 24, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-25 milestone Aug 24, 2021
@RobertaJHahn RobertaJHahn added the package: web components Work necessary for the IBM.com Library web components package label Aug 24, 2021
@meerhamzadev
Copy link

Hey👋, can I give it a try?

@RobertaJHahn RobertaJHahn changed the title [Card] CTA text doesn't wrap [Card] CTA text doesn't wrap - no DDS consultant Oct 11, 2021
@BrunnoM7 BrunnoM7 self-assigned this Oct 14, 2021
@RobertaJHahn RobertaJHahn changed the title [Card] CTA text doesn't wrap - no DDS consultant [Card] CTA text doesn't wrap Oct 18, 2021
@BrunnoM7 BrunnoM7 mentioned this issue Oct 20, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 8, 2021
@BrunnoM7
fix(card): added text wrapping to cta text (#7451)
5cf7ef3 
### Related Ticket(s)

[Card] CTA text doesn't wrap #6935

### Description

Corrects the over extension of the CTA text in the Card by wrapping it.

### Changelog

**New**

- Added the boolean property `iconInline` to `card-footer` component
- If the `iconPlacement` is set a `right` and `iconInline` is `true` text CTA will have the wrap behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunnoM7 BrunnoM7

Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Milestone
Sprint 21-22
Development

No branches or pull requests
6 participants
@jeffchew @proeung @BrunnoM7 @shixiedesign @RobertaJHahn @meerhamzadev