Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web component: Leadspace - Open canvas in new tab, gives an error page for the user #4976

Closed
Praveen-sr opened this issue Jan 22, 2021 · 1 comment
Closed

Web component: Leadspace - Open canvas in new tab, gives an error page for the user #4976

Praveen-sr opened this issue Jan 22, 2021 · 1 comment
Assignees
@kennylam
Labels
bug Something isn't working dev complete dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 1 Affects major functionality, no workaround storybook
Milestone
Sprint 21-02

Comments

@Praveen-sr
Copy link

Detailed description

Issue:
Leadspace - On knobs, edit/change 'number of buttons' or 'Icon' and then Open canvas in new tab, gives an error page for the user

Additional information

image.png
@Praveen-sr Praveen-sr added bug Something isn't working severity 1 Affects major functionality, no workaround labels Jan 22, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-02 milestone Jan 22, 2021
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package storybook Airtable Done labels Jan 22, 2021
@kennylam kennylam mentioned this issue Jan 22, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Jan 22, 2021
@kennylam
chore(storybook): add file-loader for static images (#4986)
0499e44 
### Related Ticket(s)

#4976 

### Description

This changes the `web-component` webpack to use `file-loader` instead of `url-loader`. The latter base64 encodes images, which interfere with Storybook when used in knobs.

### Changelog

**Changed**

- Web components webpack config now uses `file-loader`

<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@kennylam
Copy link
Member

@Praveen-sr @RobertaJHahn This is ready for testing http://ibmdotcom-web-components-canary.mybluemix.net/?path=/story/components-leadspace--default-with-image

IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this issue Feb 22, 2021
@kennylam @IgnacioBecerra
chore(storybook): add file-loader for static images (carbon-design-sy…
db766a1 
…stem#4986)

### Related Ticket(s)

carbon-design-system#4976 

### Description

This changes the `web-component` webpack to use `file-loader` instead of `url-loader`. The latter base64 encodes images, which interfere with Storybook when used in knobs.

### Changelog

**Changed**

- Web components webpack config now uses `file-loader`

<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
bug Something isn't working dev complete dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 1 Affects major functionality, no workaround storybook
Projects
None yet
Milestone
Sprint 21-02
Development

No branches or pull requests
4 participants
@kennylam @jeffchew @RobertaJHahn @Praveen-sr