Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Components | Documentation for dds-card-eyebrow and dds-card-heading updates #4789

Closed
jeffchew opened this issue Dec 29, 2020 · 0 comments
Closed

Web Components | Documentation for dds-card-eyebrow and dds-card-heading updates #4789

jeffchew opened this issue Dec 29, 2020 · 0 comments
Assignees
@asudoh
Labels
bug Something isn't working dev Needs some dev work documentation Improvements or additions to documentation package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 21-01

Comments

@jeffchew
Copy link
Member

Detailed description

Describe in detail the issue you're having.

Documentation for card, feature-card, etc are not updated to reflect the custom element change from the slots

Is this a feature request (new component, new icon), a bug, or a general
issue?

bug (in documentation)

Is this issue related to a specific component?

Any components using dds-card-eyebrow and dds-card-heading

What did you expect to happen? What happened instead? What would you like to
see changed?

Documentation to reflect the new usage

What browser are you working in?

n/a

What version of Carbon for IBM.com are you using?

Canary

Steps to reproduce the issue

  1. http://ibmdotcom-web-components-canary.mybluemix.net/?path=/docs/components-card--default
  2. http://ibmdotcom-web-components-canary.mybluemix.net/?path=/docs/components-content-group-cards--default
  3. http://ibmdotcom-web-components-canary.mybluemix.net/?path=/docs/components-content-block-cards--default
  4. http://ibmdotcom-web-components-canary.mybluemix.net/?path=/docs/components-feature-card-block-large--default
  5. http://ibmdotcom-web-components-canary.mybluemix.net/?path=/docs/components-feature-card-block-medium--default
  6. http://ibmdotcom-web-components-canary.mybluemix.net/?path=/docs/components-feature-card--default
@jeffchew jeffchew added the bug Something isn't working label Dec 29, 2020
@jeffchew jeffchew added dev Needs some dev work documentation Improvements or additions to documentation package: web components Work necessary for the IBM.com Library web components package labels Dec 29, 2020
@jeffchew jeffchew added this to the Sprint 20-25 milestone Dec 29, 2020
@jeffchew jeffchew added the severity 3 Affects minor functionality, has a workaround label Dec 29, 2020
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Dec 30, 2020
@asudoh
docs(card): catch up with latest change
f11bb00 
This change updates the document as we introduced `<dds-card-eyebrow>`
and `<dds-card-heading>`.

Refs carbon-design-system#4789.
@asudoh asudoh mentioned this issue Dec 30, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Dec 30, 2020
@asudoh
docs(card): catch up with latest change (#4791)
8df1437 
### Related Ticket(s)

Refs #4789.

### Description

This change updates the document as we introduced `<dds-card-eyebrow>` and `<dds-card-heading>`.

### Changelog

**Changed**

- Updates the document as we introduced `<dds-card-eyebrow>` and `<dds-card-heading>`.
@asudoh asudoh self-assigned this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

Labels
bug Something isn't working dev Needs some dev work documentation Improvements or additions to documentation package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-01
Development

No branches or pull requests
7 participants
@asudoh @jeffchew @ljcarot @IgnacioBecerra @raphaelamadeu-zz @RobertaJHahn @andysherman2121