Masthead Search click event enhancement #4599
Assignees
Labels
adopter: Docs/KC
used when component or pattern will be used by this adopter
adopter support
Feature request
A new adopter requested feature
package: react
Work necessary for the Carbon for IBM.com react components package
priority: medium
Sprint Must Have
Milestone
Comments
|
Adding just to be sure, the same interception should be applied to the keyboard (hitting ENTER) an any other possible submit event that launches the search. |
RobertaJHahn
added
adopter support
adopter: Docs/KC
|
The KC team is OK with scheduling in the Jan 2021 release |
|
Functional spec updates are needed. |
RobertaJHahn
added
the
package: react
RobertaJHahn
unassigned jeffchew, IgnacioBecerra, ghost
, raphaelamadeu-zz and JennySanchez
|
Feb 15 is their launch date |
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 15, 2021
### Related Ticket(s) #4599 ### Description This adds an optional `searchNoRedirect` prop to the `Masthead` component. When used, the masthead search will no longer redirect to the default search results page. Autosuggest items will still populate, but clicking them will not trigger a redirect. Any redirect actions must be provided in the `onSearchNoRedirect` custom event. ### Changelog **New** - `searchNoRedirect` prop to `Masthead` - `onSearchNoRedirect` custom event. Emits when `searchNoRedirect` is true **Changed** - clean up `MastheadSearch` props <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this issue
Feb 22, 2021
### Related Ticket(s) carbon-design-system#4599 ### Description This adds an optional `searchNoRedirect` prop to the `Masthead` component. When used, the masthead search will no longer redirect to the default search results page. Autosuggest items will still populate, but clicking them will not trigger a redirect. Any redirect actions must be provided in the `onSearchNoRedirect` custom event. ### Changelog **New** - `searchNoRedirect` prop to `Masthead` - `onSearchNoRedirect` custom event. Emits when `searchNoRedirect` is true **Changed** - clean up `MastheadSearch` props <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the event fired when user activates the search from masthead is an info event only.
We need a way to prevent the default action to happen, something like normal events have
e.stopPropagation or e.preventDefault
or simply if the event hook function returns True, it would mean the search was handled and
dotcom would not go to the default ibm.com search.
The text was updated successfully, but these errors were encountered: