Components: Introduce a component for heading/copy, etc. #4326
Assignees
Labels
dev
Needs some dev work
package: web components
Work necessary for the IBM.com Library web components package
Sprint Must Have
Milestone
Comments
asudoh
added
dev
asudoh
assigned kennylam, jeffchew, ghost
and jacobottesen-dgc and unassigned kennylam, jeffchew, ghost
and jacobottesen-dgc
29 tasks
asudoh
changed the title
asudoh
changed the title
asudoh
added a commit
to asudoh/ibm-dotcom-library
that referenced
this issue
Dec 29, 2020
Introduces `<dds-card-eyebrow>` and `<dds-card-heading>` to make a choice of the approach of `<div>`/`<span>` with specifying `slot` attribute vs. dedicated components to the latter, to align to other components. The dedicated components approach allows more control over styling. Refs carbon-design-system#4326.
kodiakhq bot
pushed a commit
that referenced
this issue
Dec 29, 2020
### Related Ticket(s) Refs #4326. ### Description Introduces `<dds-card-eyebrow>` and `<dds-card-heading>` to make a choice of the approach of `<div>`/`<span>` with specifying `slot` attribute vs. dedicated components to the latter, to align to other components. The dedicated components approach allows more control over styling. ### Changelog **New** - `<dds-card-eyebrow>` and `<dds-card-heading>` as a components dedicated to card eyebrow/heading, respectively.
asudoh
added a commit
to asudoh/ibm-dotcom-library
that referenced
this issue
Dec 30, 2020
Introduces `<dds-link-list-heading>` to make a choice of the approach of `<div>`/`<span>` with specifying `slot` attribute vs. dedicated components to the latter, to align to other components. The dedicated components approach allows more control over styling. Refs carbon-design-system#4326.
This was referenced Dec 30, 2020
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 4, 2021
### Related Ticket(s) Refs #4326. ### Description Introduces `<dds-link-list-heading>` to make a choice of the approach of `<div>`/`<span>` with specifying `slot` attribute vs. dedicated components to the latter, to align to other components. The dedicated components approach allows more control over styling. ### Changelog **New** - `<dds-link-list-heading>`, the heading for link list.
asudoh
added a commit
to asudoh/ibm-dotcom-library
that referenced
this issue
Jan 7, 2021
Introduces the following components: * `<dds-callout-data-heading>`: The heading (data) content. * `<dds-callout-data-copy>`: The copy content. * `<dds-callout-data-source>`: The source content. Refs carbon-design-system#4326.
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 8, 2021
### Related Ticket(s) Refs #4326. ### Description Introduces the following components: * `<dds-callout-data-heading>`: The heading (data) content. * `<dds-callout-data-copy>`: The copy content. * `<dds-callout-data-source>`: The source content. ### Changelog **New** - `<dds-callout-data-heading>`: The heading (data) content for `<dds-callout-data>`. - `<dds-callout-data-copy>`: The copy content for `<dds-callout-data>`. - `<dds-callout-data-source>`: The source content for `<dds-callout-data>`.
|
@asudoh Can this issue be closed? I looks like all of the linked PRs are merged. |
|
@RobertaJHahn Thank you for checking - Would like to keep this open if possible. Further code inspection is needed to ensure we have finished everything. |
asudoh
added a commit
to asudoh/ibm-dotcom-library
that referenced
this issue
Jan 13, 2021
Removes the `<div>` in `<dds-link-list>` surrounding `<slot name="heading">`, and makes change to `<dds-link-list-heading>` to make it work without such surrounding `<div>`. This change ensures that `<dds-link-list>` aligns the `<slot>` structure to other components like `<dds-card>`. Refs carbon-design-system#4326.
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 13, 2021
### Related Ticket(s) Refs #4326. ### Description Removes the `<div>` in `<dds-link-list>` surrounding `<slot name="heading">`, and makes change to `<dds-link-list-heading>` to make it work without such surrounding `<div>`. This change ensures that `<dds-link-list>` aligns the `<slot>` structure to other components like `<dds-card>`. ### Changelog **Changed** - `<dds-link-list-heading>` to make it work without surrounding `<div>` described below. **Removed** - `<div>` in `<dds-link-list>` surrounding `<slot name="heading">`
|
@RobertaJHahn This work is complete now. Thanks again for checking! |
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this issue
Feb 22, 2021
…ign-system#4887) ### Related Ticket(s) Refs carbon-design-system#4326. ### Description Removes the `<div>` in `<dds-link-list>` surrounding `<slot name="heading">`, and makes change to `<dds-link-list-heading>` to make it work without such surrounding `<div>`. This change ensures that `<dds-link-list>` aligns the `<slot>` structure to other components like `<dds-card>`. ### Changelog **Changed** - `<dds-link-list-heading>` to make it work without surrounding `<div>` described below. **Removed** - `<div>` in `<dds-link-list>` surrounding `<slot name="heading">`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem
Most of the components with heading contents in Web Components codebase has a corresponding component for heading contents, for the styling purpose. OTOH
<dds-link-list>doesn't.Also,
<dds-image-with-caption>supportsheadingattribute but it doesn't have a corresponding<slot>.The solution
Consider introducing a similar one for
<dds-link-list>. Also scan the codebase to see if we need any more components for heading purpose, for other areas.Additional information
Similar thing is seen with
<dds-card>, etc.The text was updated successfully, but these errors were encountered: