Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web component: Masthead - On iPhone Voice over - menu options are not available immediately after the triggering element. #3940

Closed
Praveen-sr opened this issue Sep 14, 2020 · 2 comments
Assignees
Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Milestone

Comments

@Praveen-sr
Copy link

Praveen-sr commented Sep 14, 2020

Detailed description

Jeff would like this fix included in the v1.11.0rc scheduled for Wednesday, Sept 16.

Issue:
After activating the Hamburger menu button
The options are not available immediately after the triggering element.
visually it is appearing after the triggering element but for the screen reader users it is available after navigating through the following elements:
the IBM logo link, Open IBM search field button and User profile.

Expected: screen reader should identify the control immediately after the triggering element.

Note: Working fine in react Staging.

Additional information

@Praveen-sr Praveen-sr added accessibility Has accessibility requirement bug Something isn't working severity 2 Affects major functionality, has a workaround labels Sep 14, 2020
@jeffchew jeffchew added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Sep 14, 2020
@jeffchew jeffchew added this to the Sprint 20-19 milestone Sep 14, 2020
asudoh added a commit to asudoh/carbon-custom-elements that referenced this issue Sep 15, 2020
This change ensures a side nav item is ready to be focused on before
side nav sets focus on the first nav item when it's expanded.

Refs carbon-design-system/carbon-for-ibm-dotcom#3940.
kodiakhq bot pushed a commit to carbon-design-system/carbon-web-components that referenced this issue Sep 15, 2020
* fix(side-nav): focus on end-animation

This change ensures a side nav item is ready to be focused on before
side nav sets focus on the first nav item when it's expanded.

Refs carbon-design-system/carbon-for-ibm-dotcom#3940.

* docs(examples): lock Snowpack version
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Sep 15, 2020
This change ensures correct list of nav items are selected when
`<dds-left-nav>` searches for the nav item to focus on.

Also upgrades `carbon-web-components` to `v1.6.1` to make the focusing
work.

Refs carbon-design-system#3940.
kodiakhq bot pushed a commit that referenced this issue Sep 15, 2020
### Related Ticket(s)

Refs #3940.

### Description

This change ensures correct list of nav items are selected when `<dds-left-nav>` searches for the nav item to focus on.

Also upgrades `carbon-web-components` to `v1.6.1` to make the focusing work.

### Changelog

**Changed**

- A change to ensure correct list of nav items are selected when `<dds-left-nav>` searches for the nav item to focus on.
- Upgrades `carbon-web-components` to `v1.6.1` to make the focusing work.
@annawen1
Copy link
Member

annawen1 commented Sep 17, 2020

The fix for this issue in React was to simply move the <MastheadLeftNav/> above the Logo, search, and profile components. The <HeaderContainer /> that wraps the Masthead provides a isSideNavExpanded flag which we used to determine whether the hamburger menu is open or not.

              {(navigation || mastheadL1Data) && isSideNavExpanded && (
                  <MastheadLeftNav />
                )}

                <IbmLogo
                  autoid={`${stablePrefix}--masthead-${navType}__l0-logo`}
                />

                <div className={`${prefix}--header__search ${hasPlatform}`}>
                  {navigation && !mastheadL1Data && (
                    <MastheadTopNav />
                  )}
                  {hasSearch && (
                    <MastheadSearch />
                  )}
                </div>

CC @asudoh

@asudoh
Copy link
Contributor

asudoh commented Sep 17, 2020

Thank you for the info @annawen1!

@RobertaJHahn RobertaJHahn reopened this Sep 17, 2020
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Sep 17, 2020
Changes the element order of `<dds-left-nav>` vs. the rest of the
masthead so VoiceOver cursor won't immediately go out as user moves
VoiceOver cursor after opening left nav.

Also, deactivates the focus sentinel of `<dds-masthead-menu-button>`
given it's not needed unless left nav opens and using it while left nav
is closed adds redundant tab-stop.

Refs carbon-design-system#3940.
kodiakhq bot pushed a commit that referenced this issue Sep 18, 2020
### Related Ticket(s)

Refs #3940.

### Description

Changes the element order of `<dds-left-nav>` vs. the rest of the masthead so VoiceOver cursor won't immediately go out as user moves VoiceOver cursor after opening left nav.

Also, deactivates the focus sentinel of `<dds-masthead-menu-button>` given it's not needed unless left nav opens and using it while left nav is closed adds redundant tab-stop.

### Changelog

**Changed**

- The element order of `<dds-left-nav>`.
- A change to deactivate the focus sentinel of `<dds-masthead-menu-button>` while left nav is closed.
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 16, 2022
* fix(side-nav): focus on end-animation

This change ensures a side nav item is ready to be focused on before
side nav sets focus on the first nav item when it's expanded.

Refs carbon-design-system#3940.

* docs(examples): lock Snowpack version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Projects
None yet
Development

No branches or pull requests

6 participants