Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Link with icon - On disabled, Keyboard focus is identified for the link #3712

Closed
Praveen-sr opened this issue Aug 25, 2020 · 0 comments
Closed

Component: Link with icon - On disabled, Keyboard focus is identified for the link #3712

Praveen-sr opened this issue Aug 25, 2020 · 0 comments
Assignees
@IgnacioBecerra
Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work QA QA testing work performed by the testing team members severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 20-20

Comments

@Praveen-sr
Copy link

Detailed description

Issue :- On disabled mode, Keyboard focus is identified for the link

Additional information

image.png
@Praveen-sr Praveen-sr added accessibility Has accessibility requirement bug Something isn't working severity 3 Affects minor functionality, has a workaround labels Aug 25, 2020
@RobertaJHahn RobertaJHahn added QA QA testing work performed by the testing team members Airtable Done dev Needs some dev work labels Aug 25, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-18 milestone Aug 25, 2020
@IgnacioBecerra IgnacioBecerra self-assigned this Sep 29, 2020
@IgnacioBecerra IgnacioBecerra mentioned this issue Sep 29, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 1, 2020
@IgnacioBecerra
fix(link-with-icon): removed keyboard focus on disable (#4082)
4d8ecb7 
### Related Ticket(s)

#3712 

### Description

The main issue that caused the element to still be focused even while disabled. Removed `tabIndex` as it should still respect the focus order while active and not focus during disabled state.

### Changelog

**Removed**

- Removed tabIndex from the `Link` element

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@IgnacioBecerra IgnacioBecerra reopened this Oct 1, 2020
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 2, 2020
@IgnacioBecerra @ariellalgilmore
fix(link-with-icon): removed keyboard focus on disable (carbon-design…
dfbd1fa 
…-system#4082)

### Related Ticket(s)

carbon-design-system#3712 

### Description

The main issue that caused the element to still be focused even while disabled. Removed `tabIndex` as it should still respect the focus order while active and not focus during disabled state.

### Changelog

**Removed**

- Removed tabIndex from the `Link` element

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@jeffchew jeffchew mentioned this issue Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnacioBecerra IgnacioBecerra

Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work QA QA testing work performed by the testing team members severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 20-20
Development

No branches or pull requests
4 participants
@jeffchew @IgnacioBecerra @RobertaJHahn @Praveen-sr