Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Component: Change CTA Section Reboot requested enhancement #3368

Closed
4 of 11 tasks
ibmdotcom-bot opened this issue Jul 30, 2020 · 1 comment
Closed
4 of 11 tasks

Web Component: Change CTA Section Reboot requested enhancement #3368

ibmdotcom-bot opened this issue Jul 30, 2020 · 1 comment
Assignees
@IgnacioBecerra
Labels
adopter support dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high sprint demo
Milestone
Sprint 20-22

Comments

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 30, 2020 •
edited by IgnacioBecerra
Loading

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create/change the CTA Section Reboot requested enhancement

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance criteria

  • Include README for the web component and corresponding styles
  • Create Web Components styles in styles package
  • Do not create knobs in Storybook that include JSON objects
  • Break out Storybook stories into multiple variation stories, if applicable
  • Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • If a design is provided, the Designer is included as a Reviewer in the Pull Request
  • Provide a direct link to the deploy preview for the designer in the Pull Request description
  • A comment is posted in the Design QA issue, tagging Wonil and Roberta, when development is finished
  • The Storybook link is added to the Design QA issue for their testing
  • A comment is posted in the Prod QA issue, tagging Praveen and Chetan, when development is finished
@ibmdotcom-bot ibmdotcom-bot added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Jul 30, 2020
This was referenced Jul 30, 2020
Closed
Closed
@RobertaJHahn RobertaJHahn added this to the Sprint 20-16 milestone Aug 3, 2020
@RobertaJHahn RobertaJHahn changed the title Web Component: Develop/Change CTA Section Reboot requested enhancement Web Component: Change CTA Section Reboot requested enhancement Aug 10, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 2, 2020
Closed
@jeffchew
Copy link
Member

@RobertaJHahn let's move this out out after web components work is done.

@IgnacioBecerra IgnacioBecerra mentioned this issue Nov 4, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 9, 2020
@IgnacioBecerra
feat(cta-section): web component version (#4338)
cfffb86 
### Related Ticket(s)

#3749
#3368 

### Description

Introducing the `<dds-cta-section>` component for Web Components, featuring Footer variations with Content Items and a Link List.

Default:
![Screen Shot 2020-11-04 at 3 34 01 PM](https://user-images.githubusercontent.com/24970122/98179281-3f01e480-1eb3-11eb-8334-53d4feed1472.png)

Content Items Footer:
![Screen Shot 2020-11-04 at 3 34 15 PM](https://user-images.githubusercontent.com/24970122/98179287-41fcd500-1eb3-11eb-9a72-b1ca0dd2534c.png)

Link List Footer:
![Screen Shot 2020-11-04 at 3 34 27 PM](https://user-images.githubusercontent.com/24970122/98179289-42956b80-1eb3-11eb-8724-07ffa9c9a457.png)


### Changelog

**New**

- `<dds-cta-section>` component
- `<dds-cta-section-item>` component to wrap `<dds-cta-section-heading>` and `<dds-cta-section-copy>` with the correct styling


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnacioBecerra IgnacioBecerra

Labels
adopter support dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high sprint demo
Projects
None yet
Milestone
Sprint 20-22
Development

No branches or pull requests
4 participants
@jeffchew @IgnacioBecerra @RobertaJHahn @ibmdotcom-bot