Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[card-group-item]: color-scheme doesn't work correctly #12080

Closed
2 tasks done
andy-blum opened this issue Oct 18, 2024 · 1 comment · Fixed by #12138
Closed
2 tasks done

[card-group-item]: color-scheme doesn't work correctly #12080

andy-blum opened this issue Oct 18, 2024 · 1 comment · Fixed by #12138
Assignees
@Valentin-Sorin-Nicolae
Labels
bug Something isn't working dev Needs some dev work v2

Comments

@andy-blum
Copy link
Member

andy-blum commented Oct 18, 2024 •
edited
Loading

Description

Figma Specs for inverse cards

Expected:
Image

Actual:
Image

Component(s) impacted

c4d-card-group-item, potentially other card elements

Browser

Firefox

Carbon for IBM.com version

v2-latest

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

ibm.com

Package

@carbon/ibmdotcom-web-components, @carbon/ibmdotcom-styles

CodeSandbox example

https://card-group-subgrid--carbon-demos.netlify.app/

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@andy-blum andy-blum added bug Something isn't working dev Needs some dev work labels Oct 18, 2024
@andy-blum andy-blum added the v2 label Oct 18, 2024
Merged
@Valentin-Sorin-Nicolae
Copy link
Contributor

Draft PR open - #12138

kodiakhq bot pushed a commit that referenced this issue Dec 6, 2024
@Valentin-Sorin-Nicolae
Card group item inverse color scheme (#12138)
3616719 
### Related Ticket(s)

Closes [#12080](#12080)

### Description

[Figma Specs for inverse cards](https://www.figma.com/design/oip4K9G1z0v7tLNBbDZzdr/Card-specs-v2?node-id=20-4662&t=ANH9LQPEcxOGajfN-4)

Expected:
<img width="922" alt="378000813-1c06f292-1c05-4500-a1a9-891e86774515" src="https://github.com/user-attachments/assets/233a73bf-56c5-456a-a049-70069a35e826">

Actual:
<img width="920" alt="378000836-5cccfcaa-5c6b-43ac-b3dd-7fb0b0fb2be6" src="https://github.com/user-attachments/assets/edc39a81-54a9-4a47-a4a2-e12eba330952">

Component(s) impacted

c4d-card-group-item, potentially other card elements

### Changelog

Inverse color-scheme knob added to storybook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae

Labels
bug Something isn't working dev Needs some dev work v2
Projects
Carbon for IBM.com
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Card group item inverse color scheme Valentin-Sorin-Nicolae/carbon-for-ibm-dotcom
2 participants
@andy-blum @Valentin-Sorin-Nicolae