Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature card – large]: Updates to @lg and @md #10306

Closed
2 tasks done
Tracked by #10381 ...
RichKummer opened this issue Apr 5, 2023 · 1 comment · Fixed by #10744
Closed
2 tasks done
Tracked by #10381 ...

[Feature card – large]: Updates to @lg and @md #10306

RichKummer opened this issue Apr 5, 2023 · 1 comment · Fixed by #10744
Assignees
Labels
dev Needs some dev work v2

Comments

@RichKummer
Copy link

RichKummer commented Apr 5, 2023

The problem

As part of the v2 updates, we are shifting feature card – large to a 2:1 aspect ratio for @lg and @md breakpoint

The solution

v2 specs using v11 tokens
Updated design spec using v10 tokens

Update highlights

  1. @lg and @md will use a 2:1 aspect ratio for the entire feature card
  2. See [feature card]: Add border to the card #10072 and [feature card]: Add regular color scheme #10073 for v11 tile updates using a solid border and net new default color scheme
  3. Updated alignment for copy and padding
  4. Truncation rule for body copy that is >32px from the icon at the bottom right. The heading does not truncate.
  5. When @lg and @md, the heading type token is changed to $heading-03
  6. When @md, the body copy type token is changed to $body-01
  7. Global – padding below eyebrow is adjusted from 16px to 8px

Screen Shot 2023-04-05 at 7 44 39 PM

Application/website

C4IBM.com

Business priority

Medium Priority = upcoming release but is not pressing

What time frame would this ideally be needed by (if applicable)

No response

Examples

No response

Code of Conduct

@RichKummer RichKummer added the Feature request A new adopter requested feature label Apr 5, 2023
@RichKummer RichKummer moved this to Backlog in Carbon for IBM.com Apr 5, 2023
@RichKummer RichKummer added dev Needs some dev work v2: prep preparation items for Carbon for IBM.com V2 labels Apr 5, 2023
@oliviaflory oliviaflory added v2 and removed v2: prep preparation items for Carbon for IBM.com V2 labels Apr 19, 2023
@oliviaflory oliviaflory removed the Feature request A new adopter requested feature label Jul 25, 2023
@emyarod emyarod self-assigned this Jul 28, 2023
@emyarod emyarod moved this from Backlog to Doing in Carbon for IBM.com Jul 28, 2023
@emyarod emyarod moved this from Doing to Review in Carbon for IBM.com Aug 3, 2023
@annawen1 annawen1 linked a pull request Oct 11, 2023 that will close this issue
@RichKummer
Copy link
Author

RichKummer commented Oct 24, 2023

10/24/23

Decided to separate out the design updates going into v2 launch.

v2 launch

  • Feature card sizing and layout stays the same as v1. Once content is too large for the card height, the aspect ratio will break and the card's container will expand to fit the content.
  • Added border style similar to card components #10072
  • Added color-scheme options #10073

post-v2 launch (feature enhancement)

  • We will add a prop to handle overflow situations (naming tbd):
  1. When prop is set to aspect-ratio, feature card will be locked to the 2:1 aspect ratio until @sm. Content will overflow past the bottom of the feature card container.
  2. When prop is set to flex, feature card will behave similar to v1 – card container will try adn maintain 2:1 aspect ratio and if the content would expand past that, the container would expand vertically to accommodate.

@emyarod emyarod moved this from Review to Done in Carbon for IBM.com Nov 21, 2023
@kennylam kennylam closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work v2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants