Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature card]: Add regular color scheme #10073

Closed
2 tasks done
Tracked by #10381
, #10715
...
RichKummer opened this issue Feb 21, 2023 · 0 comments · Fixed by #10744
Closed
2 tasks done
Tracked by #10381
, #10715
...

[feature card]: Add regular color scheme #10073

RichKummer opened this issue Feb 21, 2023 · 0 comments · Fixed by #10744
Assignees
@emyarod
Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package v2

Comments

@RichKummer
Copy link

RichKummer commented Feb 21, 2023 •
edited
Loading

The problem

The feature card uses an inverse background that limits its usage with the lighter and brighter brand direction. To handle this, we should add a color scheme property that enables the adopter to use both inverse (current) styles and regular (new) styles.

The regular color scheme variant should become the default color scheme for the component, with the option to use the inverse theming.

The solution

v2 specs using v11 tokens

Updated design spec using v10 tokens

Design exploration

Note: the specs contain a new border styles added in #10073.

Feature card - medium – Theme styles

Application/website

C4IBM.com

Business priority

Medium Priority = upcoming release but is not pressing

What time frame would this ideally be needed by (if applicable)

No response

Examples

No response

Code of Conduct
@RichKummer RichKummer added the Feature request A new adopter requested feature label Feb 21, 2023
@RichKummer RichKummer added dev Needs some dev work v2: prep preparation items for Carbon for IBM.com V2 labels Feb 23, 2023
@RichKummer RichKummer mentioned this issue Apr 5, 2023
Closed
2 tasks
@oliviaflory oliviaflory mentioned this issue Apr 21, 2023
Closed
@oliviaflory oliviaflory added v2 and removed v2: prep preparation items for Carbon for IBM.com V2 labels Apr 21, 2023
@oliviaflory oliviaflory added package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package labels Apr 25, 2023
@oliviaflory oliviaflory moved this to Backlog in Carbon for IBM.com Apr 25, 2023
@oliviaflory oliviaflory mentioned this issue Jul 19, 2023
Open
5 tasks
@emyarod emyarod self-assigned this Jul 20, 2023
@oliviaflory oliviaflory moved this from Backlog to Doing in Carbon for IBM.com Jul 24, 2023
@oliviaflory oliviaflory removed Feature request A new adopter requested feature package: styles Work necessary for the Carbon for IBM.com styles package labels Jul 25, 2023
@emyarod emyarod mentioned this issue Jul 26, 2023
Merged
@emyarod emyarod linked a pull request Jul 26, 2023 that will close this issue
feat(feature-card): enable color scheme selection #10744
Merged
@emyarod emyarod moved this from Doing to Review in Carbon for IBM.com Aug 3, 2023
@emyarod emyarod moved this from Review to Done in Carbon for IBM.com Nov 21, 2023
@kennylam kennylam closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package v2
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(feature-card): enable color scheme selection emyarod/carbon-for-ibm-dotcom
7 participants
@kennylam @jeffchew @emyarod @RichKummer @ljcarot @IgnacioBecerra @oliviaflory