Skip to content

Commit

Permalink
fix(rollup): fix to named exports declaration for marked dependency (#…
Browse files Browse the repository at this point in the history
…8384)

### Related Ticket(s)

Refs #8383

### Description

The namedExport declaration specific to `marked` needed to be very specific in order for the commonjs plugin in rollup to register the import correctly. This will hopefully be the fix.

### Changelog

**Changed**

- Updated `namedExports` declaration in rollup config for web components
  • Loading branch information
jeffchew authored Feb 25, 2022
1 parent 0dcaf69 commit e8fae65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
os: [ ubuntu-latest ]
node-version: [ 14.x ]
browser: [ chromium, firefox ]
browser: [ chromium ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion packages/web-components/tools/get-rollup-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ function getRollupConfig({ mode = 'development', dir = 'ltr', folders = ['dotcom
sourceMap: true,
namedExports: {
'redux-logger/dist/redux-logger.js': ['createLogger'],
'marked/lib/marked.umd.js': ['marked'],
'../utilities/node_modules/marked/lib/marked.umd.js': ['marked'],
},
}),
ibmdotcomIcon(),
Expand Down

0 comments on commit e8fae65

Please sign in to comment.