Skip to content

Commit

Permalink
fix(content-block-mixed): remove conflicting element IDs (#8219)
Browse files Browse the repository at this point in the history
### Related Ticket(s)

Resolves #8011 

### Description

Design programs often automatically add IDs to image layers when exporting as SVG. In our case, these IDs do not serve a purpose, and removing them resolves some errors reported by the `yarn test:a11y` script.

### Changelog

**Changed**

- Removed `id` attributes from SVG layers in the `dds-content-block-mixed` stories.
- Removed `id` attributes from SVG layers in the `dds-content-group-pictogram` stories.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
  • Loading branch information
jkaeser authored Feb 8, 2022
1 parent 6f4c1c1 commit 6ecdee9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* @license
*
* Copyright IBM Corp. 2020, 2021
* Copyright IBM Corp. 2020, 2022
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
Expand Down Expand Up @@ -181,8 +181,8 @@ export const Default = ({ parameters }) => {
viewBox="8 8 32 32"
xml:space="preserve"
>
<g id="touch_screen">
<g id="touch_screen_1_">
<g>
<g>
<path
style="fill:none;stroke-width:0.72;stroke-linejoin:round;stroke-miterlimit:10;"
d="M15,29H9V10h25v19h-7
Expand All @@ -193,7 +193,7 @@ export const Default = ({ parameters }) => {
/>
</g>
</g>
<g id="Layer_1"></g>
<g></g>
</svg>
<dds-content-item-heading>${itemHeading}</dds-content-item-heading>
<dds-content-item-copy>${itemCopy}</dds-content-item-copy>
Expand Down Expand Up @@ -269,8 +269,8 @@ export const WithLinkList = ({ parameters }) => {
viewBox="8 8 32 32"
xml:space="preserve"
>
<g id="touch_screen">
<g id="touch_screen_1_">
<g>
<g>
<path
style="fill:none;stroke-width:0.72;stroke-linejoin:round;stroke-miterlimit:10;"
d="M15,29H9V10h25v19h-7
Expand All @@ -281,7 +281,7 @@ export const WithLinkList = ({ parameters }) => {
/>
</g>
</g>
<g id="Layer_1"></g>
<g"></g>
</svg>
<dds-content-item-heading>${itemHeading}</dds-content-item-heading>
<dds-content-item-copy>${itemCopy}</dds-content-item-copy>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* @license
*
* Copyright IBM Corp. 2020, 2021
* Copyright IBM Corp. 2020, 2022
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
Expand Down Expand Up @@ -103,8 +103,8 @@ export const Default = ({ parameters }) => {
viewBox="8 8 32 32"
xml:space="preserve"
>
<g id="touch_screen">
<g id="touch_screen_1_">
<g>
<g>
<path
style="fill:none;stroke-width:0.72;stroke-linejoin:round;stroke-miterlimit:10;"
d="M15,29H9V10h25v19h-7
Expand All @@ -115,7 +115,7 @@ export const Default = ({ parameters }) => {
/>
</g>
</g>
<g id="Layer_1"></g>
<g></g>
</svg>
<dds-content-item-heading>${heading}</dds-content-item-heading>
<dds-content-item-copy>${copy}</dds-content-item-copy>
Expand Down

0 comments on commit 6ecdee9

Please sign in to comment.