Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expressive modal): v1 & v2 guidance updates #1731

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
52 changes: 46 additions & 6 deletions src/pages/components/expressive-modal.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,14 @@ import ResourceLinks from 'components/ResourceLinks';

<AnchorLinks>

<AnchorLink>Resources</AnchorLink>
<AnchorLink>Overview</AnchorLink>
<AnchorLink>Variations</AnchorLink>
<AnchorLink>Behavior</AnchorLink>
<AnchorLink>Resources</AnchorLink>
<AnchorLink>Feedback</AnchorLink>

</AnchorLinks>

<ResourceLinks name="Expressive modal" type="ui" />

## Overview

The default variation reflects the <a href="https://www.carbondesignsystem.com/components/modal/usage/" target="_blank">Carbon modal</a> entirely with minimal styling updates to increase the padding and usage of fixed buttons.
Expand All @@ -34,7 +33,13 @@ The default variation reflects the <a href="https://www.carbondesignsystem.com/c

<Title>Use case</Title>

![Image of Expressive modal used in a login context](../../images/component/expressive-modal/expressive-modal-default--example.jpg)
<Row>
<Column colMd={8} colLg={8}>

![Image of Expressive modal with heading and copy descriping the media](../../images/component/expressive-modal/expressive-modal-default--usecase.jpg)

</Column>
</Row>

## Variations

Expand All @@ -50,8 +55,43 @@ The expanded variation fills the screen and is typically used to display large a
</Column>
</Row>

<Title>Use case</Title>
## Behavior

### Centered in screen

![Image of Expressive modal expanded used to illustrate the IBM design thinking process](../../images/component/expressive-modal/expressive-modal-expanded--example.jpg)
Expressive Modal is standardized to appear in the center of the screen, with the dark overlay extending across the browser window.

### Overflow

When the modal content is longer than the modal height then the body section should scroll vertically.
The content should visibly fade at the end of the modal body area to indicate there is additional content out of view.
Modal content should never scroll horizontally; instead, use a larger size modal.

<Row>
<Column colMd={8} colLg={8}>
<GifPlayer>

![Image of Expressive modal overflow](../../images/component/expressive-modal/expressive-modal-overflow.gif)
![Image of Expressive modal overflow](../../images/component/expressive-modal/expressive-modal-overflow.jpg)

</GifPlayer>
</Column>
</Row>

### Closing the modal

Clicking on the close close button icon [ x ] or on the dark overlay will dismiss the modal.

<Row>
<Column colMd={8} colLg={8}>
<GifPlayer color='dark'>

![Image of Expressive modal closing](../../images/component/expressive-modal/expressive-modal-close-modal.gif)
![Image of Expressive modal closing](../../images/component/expressive-modal/expressive-modal-close-modal.jpg)

</GifPlayer>
</Column>
</Row>

<ResourceLinks name="Expressive modal" type="ui" />
<ComponentFooter name="Expressive modal" type="ui" />