Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Resources page #1524

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Updates to Resources page #1524

merged 4 commits into from
Sep 28, 2022

Conversation

oliviaflory
Copy link
Contributor

@oliviaflory oliviaflory commented Sep 27, 2022 •
edited
Loading

Related Ticket(s)

#1517

Description

  • Fixed broken links for storybooks added a / to the end of the links
  • Added Web components icon
  • Reordered: Web components, React, React wrapper
  • Fixed color contrast icon
  • Updated labels for a few icons to reflect the resource type
    • example: some said [Sketch] but were linking to IBM accessibility site or IBM Style site, not a Sketch resource

For review: https://ibmdotcom-library.s3-web.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/1524/resources/

@oliviaflory oliviaflory requested a review from a team as a code owner September 27, 2022 13:29
@oliviaflory oliviaflory requested review from RichKummer and IgnacioBecerra and removed request for a team September 27, 2022 13:29
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 27, 2022 •
edited
Loading

Deploy preview created:
https://ibmdotcom-library.s3-web.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/1524/index.html

Built with commit: 8983c634e5bba845ec30a5d21611a939895c218d

RichKummer
RichKummer approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oliviaflory oliviaflory added the Ready to merge Label for the pull requests that are ready to merge label Sep 28, 2022
@kodiakhq kodiakhq bot merged commit 2bb91d2 into main Sep 28, 2022
@kodiakhq kodiakhq bot deleted the update-resources-page branch September 28, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviaflory @ibmdotcom-bot @RichKummer