Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(footer): remove auto timestamp #1444

Merged
merged 2 commits into from
Feb 2, 2022
Merged

fix(footer): remove auto timestamp #1444

merged 2 commits into from
Feb 2, 2022

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Feb 2, 2022

Description

Removes auto-timestamp from footer, since this is already being done in CI workflow.

Changelog

Removed

  • auto-timestamp in footer

@kennylam kennylam requested a review from a team as a code owner February 2, 2022 14:13
@kennylam kennylam requested review from emyarod and removed request for a team February 2, 2022 14:13
emyarod
emyarod approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just 1 update!

src/gatsby-theme-carbon/components/Footer/index.js Outdated Show resolved Hide resolved
@emyarod emyarod mentioned this pull request Feb 2, 2022
Closed
jeffchew
jeffchew approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 2, 2022
@emyarod emyarod mentioned this pull request Feb 2, 2022
Closed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created:
https://ibmdotcom-library.s3-web.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/1444/index.html

Built with commit: 78718db44c9776da79efb9a9509ef2b13ad66b3b

@kodiakhq kodiakhq bot merged commit 2522a66 into carbon-design-system:main Feb 2, 2022
@kennylam kennylam deleted the fix/revert-auto-timestamp branch February 2, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @ibmdotcom-bot @jeffchew @emyarod