Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(environments): remove all mybluemix.net urls #1439

Merged
merged 1 commit into from
Jan 18, 2022
Merged

docs(environments): remove all mybluemix.net urls #1439

merged 1 commit into from
Jan 18, 2022

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

This removes all IBM Cloud links from the repo and switches to the latest ones.

Changelog

Changed

  • All links from mybluemix.net to the corresponding Github Pages or production links

Removed

  • Removed Carbon Expressive Theme card

@jeffchew jeffchew added the dev label Jan 18, 2022
@jeffchew jeffchew self-assigned this Jan 18, 2022
@jeffchew jeffchew requested a review from a team as a code owner January 18, 2022 19:29
@jeffchew jeffchew requested review from oliviaflory and annawen1 and removed request for a team January 18, 2022 19:29
emyarod
emyarod approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Jan 18, 2022
Closed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created:
https://ibmdotcom-library.s3-web.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/1439/index.html

Built with commit: d3120115d0e155e4b6ff309f6c86bc7486832cdc

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 18, 2022
@kodiakhq kodiakhq bot merged commit 944ee3b into carbon-design-system:main Jan 18, 2022
oliviaflory
oliviaflory reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jeffchew 🎉

@oliviaflory oliviaflory mentioned this pull request Jan 19, 2022
Closed
@jeffchew jeffchew deleted the docs/remove-ibm-cloud-links branch May 9, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviaflory oliviaflory oliviaflory left review comments

@emyarod emyarod emyarod approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffchew @ibmdotcom-bot @emyarod @oliviaflory