Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cta): update cta heading font size #201

Merged
merged 2 commits into from
Mar 7, 2022
Merged

fix(cta): update cta heading font size #201

merged 2 commits into from
Mar 7, 2022

Conversation

kennylam
Copy link
Member

Related Ticket(s)

carbon-design-system/carbon-for-ibm-dotcom#8312

Description

Update copy prop with heading for content block CTA.

Changelog

Changed

  • copy prop changed to heading for all pages
  • misc copy changes
  • update ibm-dotcom deps to latest

@kennylam kennylam requested a review from a team as a code owner February 24, 2022 04:41
@kennylam kennylam changed the title fix(cta): replace copy with heading fix(cta): replace copy with heading Feb 24, 2022
@kennylam kennylam changed the title fix(cta): replace copy with heading fix(cta): update cta heading font size Feb 24, 2022
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created:
https://ibmdotcom-nextjs.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/201/index.html

Built with commit: 3f3acdab0954b41bc6dd1233aeed96056463ef74

emyarod
emyarod approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Mar 7, 2022
Closed
RichKummer
RichKummer approved these changes Mar 7, 2022
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the correct type token. TY!

@RichKummer RichKummer mentioned this pull request Mar 7, 2022
Closed
@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Mar 7, 2022
@kodiakhq kodiakhq bot merged commit 6898de5 into carbon-design-system:main Mar 7, 2022
@kennylam kennylam deleted the fix/cta-heading-font-size-8312 branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@emyarod emyarod emyarod approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@RichKummer RichKummer

Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @ibmdotcom-bot @emyarod @RichKummer