Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency eslint-config-prettier to v8 #149

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 18, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-prettier ^5.0.0 -> ^8.0.0 age adoption passing confidence

Release Notes

prettier/eslint-config-prettier

v8.3.0

Compare Source

v8.2.0

Compare Source

  • Added: [flowtype/quotes]. Thanks to Martin Zlámal (@​mrtnzlml)!

v8.1.0

Compare Source

  • Added: [flowtype/object-type-curly-spacing].
  • Added: Dummy files for the configs removed in 8.0.0. The dummy files throw an error that try to guide you how to upgrade.

v8.0.0

Compare Source

  • Changed: All configs have been merged into one!

    To upgrade, change:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier",
        "prettier/@​typescript-eslint",
        "prettier/babel",
        "prettier/flowtype",
        "prettier/react",
        "prettier/standard",
        "prettier/unicorn",
        "prettier/vue"
      ]
    }

    Into:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier"
      ]
    }

    The "prettier" config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!

    So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@​lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@​thorn0) for pointing this out!

    If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:

    {
      "extends": [
        "some-other-config-you-use",
        "plugin:prettier/recommended"
      ]
    }

    (The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main "prettier" config does not include the rules from it.)

  • Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).

v7.2.0

Compare Source

v7.1.0

Compare Source

  • Added: [unicorn/empty-brace-spaces]. Thanks to fisker Cheung (@​fisker)!

v7.0.0

Compare Source

  • Changed: At least ESLint 7.0.0 is now required.

  • Changed: [arrow-body-style] and [prefer-arrow-callback] are no longer turned off by default. They only need to be turned off if you use [eslint-plugin-prettier]. If you do, add "prettier/prettier" to your "extends" array to turn them off again.

    {
      "extends": ["prettier", "prettier/prettier"],
      "plugins": ["prettier"],
      "rules": {
        "prettier/prettier": "error"
      }
    }

    Alternatively, update [eslint-plugin-prettier] to version 3.2.0 or later which automatically turns off these two rules in its "plugin:prettier/recommended" config.

    The CLI helper tool only warns about these rules if you have the "prettier/prettier" rule enabled for a file.

  • Changed: no-tabs is now a validatable rule. If you use it, you should enable allowIndentationTabs so that the rule works regardless of your Prettier config:

    {
      "rules": {
        "no-tabs": ["error", { "allowIndentationTabs": true }]
      }
    }
  • Changed: The CLI helper tool is now called just eslint-config-prettier instead of eslint-config-prettier-check. This is so that npx eslint-config-prettier always works regardless of whether you have already installed eslint-config-prettier or not: If you have, the local installation is used; if you haven’t, npx downloads a temporary copy.

  • Changed: The CLI helper tool no longer requires you to pipe the output of eslint --print-config to it. Instead, it does that automatically for you via ESLint API:s added in ESLint v7.

    Before:

    npx eslint --print-config index.js | npx eslint-config-prettier-check
    

    After:

    npx eslint-config-prettier index.js
    
  • Improved: The npm package is now 75% smaller.

v6.15.0

Compare Source

v6.14.0

Compare Source

  • Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to @​xcatliu!

v6.13.0

Compare Source

  • Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to @​xcatliu!

v6.12.0

Compare Source

v6.11.0

Compare Source

v6.10.1

Compare Source

  • Improved: Recommend using npx when running the CLI helper tool.
  • Updated: Mention that eslint-config-prettier has been tested with Prettier 2.0 and the latest versions of plugins.

v6.10.0

Compare Source

v6.9.0

Compare Source

v6.8.0

Compare Source

v6.7.0

Compare Source

v6.6.0

Compare Source

  • Added: New [eslint-plugin-vue] rules: [vue/dot-location] and [vue/keyword-spacing]. Thanks to @​xcatliu!

v6.5.0

Compare Source

  • Added: Support for [excluding deprecated rules]. Thanks to Alex Ilyaev (@​alexilyaev)!

v6.4.0

Compare Source

  • Added: [unicorn/no-nested-ternary]. Thanks to Yang Mingshan (@​yangmingshan)!

v6.3.0

Compare Source

v6.2.0

Compare Source

v6.1.0

Compare Source

  • Added: [function-call-argument-newline] (new in ESLint 6.2.0). Thanks to Masafumi Koba (@​ybiquitous)!

v6.0.0

Compare Source

  • Changed: The CLI helper tool now considers [no-confusing-arrow] to conflict if you use the default value of its allowParens option. The default was changed to true in ESLint 6, which conflicts with Prettier.

    If the CLI helper tool gives you errors about this after upgrading, the solution is to change this:

    {
      "rules": {
        "no-confusing-arrow": ["error"]
      }
    }

    Into this:

    {
      "rules": {
        "no-confusing-arrow": ["error", { "allowParens": false }]
      }
    }

    The latter works in both ESLint 6 as well as in ESLint 5 and older.

  • Improved: eslint --print-config usage instructions. The CLI tool help text as well as the documentation has been updated to suggest commands that work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of eslint --print-config ., use eslint --print-config path/to/main.js.)


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner November 18, 2021 02:20
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch 2 times, most recently from 0cde881 to c32775f Compare November 18, 2021 03:34
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 18, 2021

@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch 2 times, most recently from 115515a to 5cad3b8 Compare November 18, 2021 04:51
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 18, 2021
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from 5cad3b8 to c3f42dd Compare November 18, 2021 23:20
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch 2 times, most recently from 36cb4a6 to ce4ba67 Compare November 20, 2021 16:58
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Nov 20, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 20, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from ce4ba67 to 402cd4a Compare November 20, 2021 17:48
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 20, 2021
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from 402cd4a to 4dfc6be Compare November 20, 2021 18:38
@kodiakhq kodiakhq bot merged commit 9380ba5 into master Nov 20, 2021
@kodiakhq kodiakhq bot deleted the renovate/eslint-config-prettier-8.x branch November 20, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants