Replace node-sass by dart-sass #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusbandeiraa
force-pushed
the
replace-node-sass
branch
from
3eb56dc
to
299206c
Compare
|
✔️ Deploy Preview for carbon-components-vue ready! 🔨 Explore the source changes: 299206c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/6143a260eea7ec0008c52497 😎 Browse the preview: https://deploy-preview-1253--carbon-components-vue.netlify.app |
|
✔️ Deploy Preview for carbon-components-vue ready! 🔨 Explore the source changes: 9f188d4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/6143a63ab9071300089b9283 😎 Browse the preview: https://deploy-preview-1253--carbon-components-vue.netlify.app |
lee-chase
approved these changes
Sep 28, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1250
What did you do?
node-sassdev dependencysassversion^1.41.0) dependencycarbon-componentsto version^10.43.0.yarn-offline-mirrordependenciesWhy did you do it?
Why did I replace node-sass by dart-sass?
Node-sass was deprecated, and also forced Windows developers to install additional dependencies in order to build the project successfully, which was annoying, at minimum. Dart-sass is the recommended replacement.
Why did I update carbon-components?
Previous to version 10.43.0, carbon-components used
/for division operations in*.scssfiles. This feature was deprecated and will stop working in sass 2; This didn't cause any problem, but generated lots of warnings in the terminal at build-time. On version 10.43.0 and newer, the slash symbol was replaced bymath.div.Why did I update .yarn-offiline-mirror dependencies?
CircleCI was failing to fetch newer versions, because they weren't included in the offline mirror. I added the missing dependencies and also pruned the folder to remove unused dependencies.
How have you tested it?
I built the project. Was able to validate it works on the storybook.
Were docs updated if needed?
I can split this PR into 2 if necessary (one updating carbon-components and another one updating sass)