fix: change label HTML tag in cv-file-uploader component #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change label tag from strong to p for semantic reasons
|
Deploy preview for carbon-components-vue ready! Built with commit 0802f8b https://deploy-preview-1145--carbon-components-vue.netlify.app |
There was a problem hiding this comment.
It does look good to me. @lee-chase, was there a specific reason to use the strong tag?
|
This change would need to go through core carbon as our HTML mirrors that. Raised an issue with core Carbon. |
lee-chase
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Hello guys,
We have an accessbility issue in cv-file-uploader component label,
<strong/>tag is not the best option for heading contents. To fix this issue I tried to change to<p/>tag, so the Accessbility Checker stoped warning about this problem. Can you check if the alteration is possible?Before:
After:
Changelog
M packages/core/src/components/cv-file-uploader/cv-file-uploader.vue