This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(tabs): dropdown label matches updated tabs #2196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 43ae151 https://deploy-preview-2196--carbon-components-react.netlify.com |
|
Hi @jinhei could you create an issue with a reduced case based on https://codesandbox.io/s/github/IBM/carbon-components-react/tree/master/examples/codesandbox? We encourage contributors to enter issues accompanied with PRs except for small/internal chores. Thanks! |
|
@asudoh See #2204 |
|
Superseded by #2224 - Sorry for this, I found |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2204 where the wrong selected dropdown label is shown when
props.childrenandprops.selectedare both updated.Currently, updating
props.childrenandprops.selectedat the same time usesprevProps.children's label in the dropdown. This occurs becausegetTabAtchecks the refs cached in the class, which are not updated untilrefis called (afterselectedLabelis populated).