This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
feat(ComposedModal): support selectorPrimaryFocus prop #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 972a500 https://deploy-preview-1634--carbon-components-react.netlify.com |
joshblack
approved these changes
Dec 11, 2018
|
Related to focus, would we ever want to have our patterns follow what we do in UI Shell: e.g. basically make it so that children need to support a |
docs(ComposedModal): add selectorPrimaryFocus knob
emyarod
force-pushed
the
1623-composedmodal-selectorprimaryfocus
branch
from
1aa4fe5 to
368bf79
Compare
|
sure, I have updated with some test cases for |
|
Thanks you for adding the tests @emyarod! |
|
🎉 This PR is included in version 6.61.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IBM/carbon-components-react#1623
This PR adds support for the
selectorPrimaryFocusprop on<ComposedModal>to match<Modal>and<ModalWrapper>Related: #980 #1124 #1621 #1633
Changelog
New
<Modal>)<ComposedModal>s using<ModalFooter><ComposedModal>with trigger buttonChanged
<Modal>methods before they are called