Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of bx--search-magnifier-icon in search component #1820

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

PPPiQ
Copy link

@PPPiQ PPPiQ commented May 14, 2021

Closes IBM/carbon-components-angular#

Update of class for search component from
bx--search-magnifier
to
bx--search-magnifier-icon

acording to recomendation from carbon-designe under this merge: carbon-design-system/carbon#8101

Changelog

Changed

search.component.html
class:
bx--search-magnifier
changed to:
bx--search-magnifier-icon

@PPPiQ PPPiQ requested a review from a team as a code owner May 14, 2021 06:51
@PPPiQ PPPiQ requested review from cal-smith and zvonimirfras May 14, 2021 06:51
@netlify
Copy link

netlify bot commented May 14, 2021

✔️ Deploy Preview for carbon-components-angular ready!

🔨 Explore the source changes: 5245a58

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-angular/deploys/60d4b8514d0e430007b02287

😎 Browse the preview: https://deploy-preview-1820--carbon-components-angular.netlify.app/iframe

Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix this! Just one suggestion, but otherwise looks good to me

src/search/search.component.html Show resolved Hide resolved
@dbrandl28
Copy link

Hi, just checking on the status of this issue - it is blocking me from upgrading.

Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating carbon-components did the trick, thanks for your patience @PPPiQ!

@cal-smith cal-smith merged commit aef349b into carbon-design-system:master Jun 24, 2021
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 4.53.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dbrandl28
Copy link

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants