Add an AlertModalComponent #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes table not centring properly in its parent container.
… border." This reverts commit f808411.
….show()`. Added new storybook sections. Updated Modal styles to match Carbon's. Fixed docs.
stanislavgeorgiev
requested review from
cal-smith,
magedhennawy and
zvonimirfras
as code owners
cal-smith
suggested changes
Sep 20, 2018
Renamed `elRef` to `elementRef`.
cal-smith
suggested changes
Sep 21, 2018
|
Also it seems like travis is sad for some reason, looks like lint errors |
|
Travis checks are now passing :) |
zvonimirfras
requested changes
Sep 24, 2018
src/modal/modal.stories.ts
Outdated
| .add("Passive", () => ({ | ||
| template: ` | ||
| <app-alert-modal-story [modalType]="modalType" [headerLabel]="headerLabel" [title]="title" [text]="text" | ||
| ></app-alert-modal-story> |
There was a problem hiding this comment.
We don't normally put lone >s on a separate line.
zvonimirfras
requested changes
Sep 26, 2018
| @@ -13,7 +13,7 @@ import { Modal, ModalService } from "../"; | |||
| selector: "app-sample-modal", | |||
| template: ` | |||
| <ibm-modal> | |||
| <ibm-modal-header (closeSelect)="closeModal()">Header text</ibm-modal-header> | |||
| <ibm-modal-header (closeSelect)="closeModal()">header label</ibm-modal-header> | |||
There was a problem hiding this comment.
Yeah, label is fine, I was just trying to point out the lowercase to uppercase H :)
Sorry for being a bit ambiguous.
…ular into AlertModalComponent
zvonimirfras
requested changes
Sep 27, 2018
| @@ -13,7 +13,7 @@ import { Modal, ModalService } from "../"; | |||
| selector: "app-sample-modal", | |||
| template: ` | |||
| <ibm-modal> | |||
| <ibm-modal-header (closeSelect)="closeModal()">Header text</ibm-modal-header> | |||
| <ibm-modal-header (closeSelect)="closeModal()">header label</ibm-modal-header> | |||
There was a problem hiding this comment.
Can we get a capital H in header label so it would be Header label, pretty please? :)
You can even name it Modal heading to match vanilla and React flavors.
|
Sure, would we be able to deliver it after and do incremental updates if
needed? I need to integrate that dialog in the project already :-)
Thanks,
Stan.
…On Thu, Sep 27, 2018, 4:07 PM Zvonimir Fras, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/modal/modal.stories.ts
<#100 (comment)>
:
> @@ -13,7 +13,7 @@ import { Modal, ModalService } from "../";
selector: "app-sample-modal",
template: `
<ibm-modal>
- <ibm-modal-header (closeSelect)="closeModal()">Header text</ibm-modal-header>
+ <ibm-modal-header (closeSelect)="closeModal()">header label</ibm-modal-header>
Can we get a capital H in header label so it would be Header label,
pretty please? :)
You can even name it Modal heading to match vanilla and React flavors.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#100 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMgXYcCFQmZ67H-35BOb8wOgglvQVdKks5ufTAXgaJpZM4WynTs>
.
|
|
Sure that sounds fine with me |
cal-smith
approved these changes
Sep 28, 2018
|
🎉 This PR is included in version 1.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95