-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CSS pollution) #1671
Merged
theiliad
merged 7 commits into
carbon-design-system:master
from
nstuyvesant:grid-bg-fix
Sep 25, 2023
Merged
fix(CSS pollution) #1671
theiliad
merged 7 commits into
carbon-design-system:master
from
nstuyvesant:grid-bg-fix
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstuyvesant
requested review from
theiliad,
Akshat55 and
a team
as code owners
September 25, 2023 02:21
nstuyvesant
requested review from
zvonimirfras
and removed request for
a team
September 25, 2023 02:21
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
theiliad
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
--cds--chart-holder
. This caused the style sheet to overwrite CSS custom properties set by@carbon/styles
and related packages.@carbon/styles
.Demo screenshot or recording
This StackBlitz example submitted with bug 1669 has the newly generated CSS pasted in place of the import:
https://stackblitz.com/edit/github-skkfec-q6ryuo?file=src%2Findex.scss