-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): add addon-docs, remove addon-info and storybook-readme #2414
Conversation
✔️ Deploy Preview for ai-apps-pal-angular ready! 🔨 Explore the source changes: 0778f98 🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/60da0f237101ae0008730605 😎 Browse the preview: https://deploy-preview-2414--ai-apps-pal-angular.netlify.app/iframe |
✔️ Deploy Preview for carbon-addons-iot-react ready! 🔨 Explore the source changes: 0778f98 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/60da0f236cb43300073a7362 😎 Browse the preview: https://deploy-preview-2414--carbon-addons-iot-react.netlify.app/iframe |
…on-addons-iot-react into 963-addon-docs
…on-addons-iot-react into 963-addon-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, a small changes needed and there were some questions about dependencies
nice catch! I'll copy the MDX file from Carbon to prevent it and give better docs--this probably something we'll need to do eventually anyway, I assume. We were hoping carbon would bundle the MDX and we could just use then, but I don't know if that's going to happen or not. |
It is not just the modal, but all stories that use the modal as well :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Closes #963
Closes #2418
Blocked until #2359 and #2336 are merged.Summary
Change List (commits, features, bugs, etc)
Component w/ stories using
storybook-readme
that were updatedAcceptance Test (how to verify the PR)
Regression Test (how to make sure this PR doesn't break old functionality)