Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overrides #27

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix overrides #27

merged 2 commits into from
Feb 28, 2024

Conversation

bucko13
Copy link
Contributor

@bucko13 bucko13 commented Feb 28, 2024

in order for overrides to be applied in an npm project with workspaces, you need to add the dependencies whose upstream dependencies you want to lock into the top level package.json where the overrides are applied (you can't apply them at the workspace level: npm/cli#4834)

This was originally fixed in the legacy repo here: unchained-capital/unchained-wallets#137

We're still waiting for an actual fix from @LedgerHQ

Copy link

changeset-bot bot commented Feb 28, 2024

⚠️ No Changeset found

Latest commit: 67ba48b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview Feb 28, 2024 5:22pm

Copy link
Contributor

@dylan-thompson dylan-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing and confirm address on device are both working on ledger

@bucko13 bucko13 merged commit 19d1735 into main Feb 28, 2024
4 checks passed
@bucko13 bucko13 deleted the fix-overrides branch February 28, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants