Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turbo dev depends on build w/ esbuild noExternal #164

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

bucko13
Copy link
Contributor

@bucko13 bucko13 commented Dec 17, 2024

I noticed that after making the change in 5c3c456 turbo.json needed to define build as a dependency for dev tasks since the noExternal dep would need to be pre-built and bundled. I noticed this was breaking when trying to run npm run dev fresh.

@bucko13 bucko13 requested a review from chadchapnick December 17, 2024 21:31
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: e911c8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 11:25pm

Copy link
Contributor

@chadchapnick chadchapnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the development server for the coordinator with a fresh install, and that the HEAD of main will currently error out if the ^build dependency is not specified.

@bucko13 bucko13 merged commit 2babad3 into caravan-bitcoin:main Dec 23, 2024
3 checks passed
@bucko13 bucko13 deleted the fix-dev-build branch December 23, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants