Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invert logic of isActiveJobStatus helper function #354

Merged

Conversation

deadlycoconuts
Copy link
Contributor

Context

This context inverts the logic of the isActiveJobStatus helper function used in the UI, since its name doesn't really represent what it actually does (it actually does the inverse 👀)

@deadlycoconuts deadlycoconuts self-assigned this Jul 27, 2023
@deadlycoconuts deadlycoconuts marked this pull request as draft July 27, 2023 09:22
@deadlycoconuts deadlycoconuts marked this pull request as ready for review July 28, 2023 02:01
Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this fix!

@deadlycoconuts deadlycoconuts merged commit ec567ae into caraml-dev:main Jul 28, 2023
12 checks passed
@deadlycoconuts deadlycoconuts deleted the fix_inconsistent_function_name branch September 7, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants