Add Edit Metadata Page & Codecov integration #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
deadlycoconuts
requested changes
May 6, 2024
ui/packages/app/src/project_setting/metadata/UpdateMetadataModalForm.js
Outdated
Show resolved
Hide resolved
ui/packages/app/src/project_setting/metadata/UpdateMetadataModalForm.js
Outdated
Show resolved
Hide resolved
leonlnj
reviewed
May 7, 2024
leonlnj
reviewed
May 7, 2024
leonlnj
reviewed
May 7, 2024
leonlnj
reviewed
May 7, 2024
ui/packages/app/src/project_setting/project_info/ProjectInfoForm.js
Outdated
Show resolved
Hide resolved
ui/packages/app/src/project_setting/project_info/ProjectInfoForm.js
Outdated
Show resolved
Hide resolved
ui/packages/app/src/project_setting/project_info/ProjectInfoForm.js
Outdated
Show resolved
Hide resolved
ui/packages/app/src/project_setting/project_info/UpdateProjectInfoModal.js
Outdated
Show resolved
Hide resolved
ui/packages/app/src/project_setting/project_info/UpdateProjectInfoModal.js
Outdated
Show resolved
Hide resolved
leonlnj
reviewed
May 16, 2024
leonlnj
reviewed
May 16, 2024
jonathanv28
force-pushed
the
update-branch
branch
from
c27629e
to
54a68f6
Compare
jonathanv28
changed the title
ui/packages/app/src/project_setting/project_info/UpdateProjectInfoModal.js
Outdated
Show resolved
Hide resolved
deadlycoconuts
approved these changes
May 17, 2024
There was a problem hiding this comment.
LGTM! 🚀 Thanks a lot for your patience in constantly reiterating through multiple versions of this PR! I think it looks good in general right now so I'll be approving it. I'll leave it to the rest to see if they have any other comments. If they don't, feel free to merge this PR anytime!
P.S. Can you also resolve those threads that you've addressed? 😅
added 6 commits
May 20, 2024 15:07
jonathanv28
force-pushed
the
update-branch
branch
from
643c58d
to
daeb712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some additional views to modify and manage MLP Project metadata through the UI. The metadata in question are
stream,team, andlabels. Additionally, codecov.io integration is also added as a part to have MLP’s API code coverage.Things updated:
test-apijob.