chore: use ctx background when calling webhook async #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When trying to call a webhook within an API call, the context that usually will be passed is request context. Issue is, this context will expire when the client API call is done (either by timeout, cancel, or finished process), therefore when calling the async webhook with
NewRequestWithContext
it might produce an error because the request will not wait for aync call, as it's called in another go routine.To mitigate this issue, the async webhook call will use
context.Background()
instead.