Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-lib): Bump up sentry browser package version #106

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Jun 28, 2024

Context

In #100, the version of the sentry/browser package used in the MLP app UI has been updated to v8.5.0. However, the same wasn't done to the MLP UI library, which is still stuck at v5.15.5.

This PR bumps up the version of sentry/browser, and similarly bumps up the version of the MLP UI library, which hasn't been updated for ages (this also allows the CICD pipeline to cut and release a new version of the MLP UI library).

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Jun 28, 2024
@deadlycoconuts deadlycoconuts self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (8a02334) to head (8436f0a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          47       47           
  Lines        2443     2443           
=======================================
  Hits         1396     1396           
  Misses        851      851           
  Partials      196      196           
Flag Coverage Δ
api-test 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@deadlycoconuts deadlycoconuts merged commit d1f1876 into caraml-dev:main Jul 4, 2024
10 checks passed
@deadlycoconuts deadlycoconuts deleted the bump_up_sentry_browser_pkg_in_ui_lib branch July 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants