Formula parser & alias cleanup & rich-based help #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2022
This was
linked to
issues
Mar 31, 2022
Closed
This was referenced Mar 31, 2022
This was
linked to
issues
Mar 31, 2022
SpheMakh
requested changes
Apr 4, 2022
| @@ -9,13 +9,19 @@ | |||
| requirements = ["pyyaml", | |||
| "nose>=1.3.7", | |||
| "future-fstrings", | |||
| "scabha @ git+https://github.com/caracal-pipeline/scabha2", | |||
| "scabha >= 0.7.0", | |||
There was a problem hiding this comment.
Then we should just remove the scabha dependency for now. Because scabha 0.7.0 is not on pypi, and it makes no sense to require it.
There was a problem hiding this comment.
Or we could just merge the scabha PR and make a release?
stimela/commands/run.py
Outdated
| from stimela.config import ConfigExceptionTypes | ||
| import click | ||
| import logging | ||
| import os.path, yaml, sys | ||
| import os.path, yaml, sys, asyncio |
There was a problem hiding this comment.
Not kosher. Unless importing from the same module/library, each import should be on a new line
There was a problem hiding this comment.
PEP-8 says "Imports should usually be on separate lines", so I tend to interpret that loosely. Particularly when a large number of the usual standard library suspects are imported, like import os, os.path, sys etc. I just find the import section gets too big.
|
@SpheMakh please approve and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matched set with caracal-pipeline/scabha2#21.