FIASCO III: Kubernetes backend functional #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleanups and fixes to logic for checking file existence * added NOSUBST() function to parser which disables substitutions in its argument * minor fixes to singularity backend
…s of subrecipe substeps being skipped
…etwork fault tolerance
Minor fixes for kube backend.
Very minor fix for strings which don't include a space.
|
@SpheMakh I don't think you're keeping up enough to possibly meaningfully review this... shall I just use superpowers to do a bulk merge to master? This branch has effectively been our master for a long time anyway. |
|
Sure, please merge. But let's not do these bulky PRs moving forward. |
SpheMakh
approved these changes
Jan 24, 2024
Only if you promise to review as fast as we code! 🤣 But also @Athanaseus can help next time. I've pushed an 2.0rc8 release, and will update cult-cargo accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.