Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aosp-13] Vibration support is broken #5

Open
fabricedesre opened this issue Nov 8, 2022 · 1 comment
Open

[aosp-13] Vibration support is broken #5

fabricedesre opened this issue Nov 8, 2022 · 1 comment

Comments

@fabricedesre
Copy link 

11-08 19:42:13.922  1737  9307 I Gecko   : Failed to run vibration pattern: vibrator == nullptr
@fabricedesre
Copy link
Author

The vibrator hardware interface moved from HIDL to AIDL, hal/gonk/GonkHal.cpp needs to be updated accordingly.

fabricedesre pushed a commit that referenced this issue Dec 16, 2022
@mfromanmoz
Bug 1800920 - Vendor libwebrtc from 6ced79beec
5a44a48 
Upstream commit: https://webrtc.googlesource.com/src/+/6ced79beecdf6ec669840f3ca9d9695cfdbf9376
    Add additional checks in case of early portal error

    In case ScreenCast portal fails right at the beginning, we need to check
    the response before trying to get session handle to avoid accessing
    non-existing portal data.

    Also on early failure do not continue making source request if we failed
    before and don't have session handle.

    (cherry picked from commit 65a9a515b51be1050bbb6fcb1edfbdff706434bf)

    Bug: webrtc:13429, chromium:1363783
    Change-Id: I2bfbd2c6e96e3cda1e62aa9dc07f66d4c7496b53
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272400
    Reviewed-by: Alexander Cooper <[email protected]>
    Reviewed-by: Mark Foltz <[email protected]>
    Commit-Queue: Mark Foltz <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#37872}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275961
    Commit-Queue: Alexander Cooper <[email protected]>
    Reviewed-by: Mirko Bonadei <[email protected]>
    Cr-Commit-Position: refs/branch-heads/5249@{#5}
    Cr-Branched-From: 7aaeb5a270ba23f5844f7301a50aaff9b6ca6126-refs/heads/main@{#37825}
fabricedesre pushed a commit that referenced this issue Jan 23, 2023
@Drekabi
Bug 1806510 - Vendor libwebrtc from 64edb15e1e
663bdb4 
Upstream commit: https://webrtc.googlesource.com/src/+/64edb15e1e5bb86bbcb78f0e8be0a6559097f3f3
    Make P2PTransportChannel implement IceAgentInterface (#5/n)

    This functionally no-op change adds the methods to allow an active ICE controller to manipulate the connection used by the ICE transport. Most methods reuse existing code, this will be explicitly marked for cleanup with a follow-up CL which adds active ICE controller support.

    Non-trivial changes are needed for P2PTransportChannel unit tests to cover the new code, and these are also being added in a follow-up CL.

    Bug: webrtc:14367, webrtc:14131
    Change-Id: I4f012efcd8cb5766eb8c6f0872de50f8375f3a73
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275301
    Reviewed-by: Jonas Oreland <[email protected]>
    Commit-Queue: Sameer Vijaykar <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#38081}
fabricedesre pushed a commit that referenced this issue Jan 23, 2023
@Drekabi
Bug 1806510 - Vendor libwebrtc from 4005adc6d6
bcac480 
Upstream commit: https://webrtc.googlesource.com/src/+/4005adc6d639035fdd5323861d9a2fc6bd946e99
    [M107] ice: include tiebreaker in computation of foundation attribute

    the foundation attribute is currently calculated as
      CRC32(baseaddress, protocol, relayprotocol)
    which is a way to satisfy the requirements from
      https://www.rfc-editor.org/rfc/rfc5245#section-4.1.1.3

    However, this leaks the base address which defeats the
    MDNS obfuscation described in
      https://datatracker.ietf.org/doc/draft-ietf-mmusic-mdns-ice-candidates/
    since the CRC32 can be reversed using a table lookup as shown in
      https://github.com/niespodd/webrtc-local-ip-leak/

    To defeat that lookup, "seed" the CRC32 with the ICE tie-breaker which is a randomly picked unsigned 64 bit integer described in
      https://www.rfc-editor.org/rfc/rfc5245#section-5.2

    The tie-breaker is not known to Javascript and adding it scopes the foundation within the peer connection as described in section 4.1.1.3

    To manually test (preferably with a DCHECK for IceTiebreaker() in ComputeFoundation)
    - gather candidates twice on https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/ and observe that the foundations are not the same after this change
    - create two RTCPeerConnections with {iceCandidatePoolSize: 1}, create a datachannel, call setLocalDescription, inspect the candidates and observe that the foundations are not the same after this change.

    Unit test changes have been split into a separate CL for easier integration.

    BUG=webrtc:14605,chromium:1378916

    (cherry picked from commit 08b882d762edadb9797334859d915c5c1e34896b)

    Change-Id: I6bbad1635b48997b00ae74d251ae357bf8afd12f
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280621
    Reviewed-by: Harald Alvestrand <[email protected]>
    Reviewed-by: Jonas Oreland <[email protected]>
    Commit-Queue: Harald Alvestrand <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#38485}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281421
    Commit-Queue: Philipp Hancke <[email protected]>
    Cr-Commit-Position: refs/branch-heads/5304@{#5}
    Cr-Branched-From: 024bd84ca1cf7d3650c27912a3b5bfbb54da152a-refs/heads/main@{#38083}
fabricedesre pushed a commit that referenced this issue Apr 12, 2023
@docfaraday
Bug 1822194 - Vendor libwebrtc from 218b56e516
0408cf5 
Upstream commit: https://webrtc.googlesource.com/src/+/218b56e516386cd57c7513197528c3124bcd7ef3
    Fix Destruction inside WGC Callback

    If we are notified of the destruction of the window before a
    CaptureFrame call can fail, then we may end up attempting to destroy the
    underlying WGC object inside it's own event handler. This can be
    problematic, as the class itself may want to run other code. Instead,
    we just unsubscribe and signal that any future CaptureFrame calls should
    reject.

    This also removes setting "is_capture_started_=false" in the item closed
    handler, as all that served to do is cause the WgcCapturerWin code to
    attempt to restart the capturer, and somewhat muddies up our metrics.

    (cherry picked from commit 318cf28945d80a0ac6f09382e507c95e649cc4c1)

    Bug: chromium:1413005
    No-Try: True
    Change-Id: Ibccb7a2e7ce531ba80b4b331b9bc2cda0ff75f4e
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/292762
    Auto-Submit: Alexander Cooper <[email protected]>
    Reviewed-by: Mark Foltz <[email protected]>
    Commit-Queue: Mark Foltz <[email protected]>
    Commit-Queue: Alexander Cooper <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#39275}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293246
    Bot-Commit: [email protected] <[email protected]>
    Cr-Commit-Position: refs/branch-heads/5481@{#5}
    Cr-Branched-From: 2e1a9a4ae0234d4b1ea7a6fd4188afa1fb20379d-refs/heads/main@{#38901}
fabricedesre pushed a commit that referenced this issue Aug 3, 2023
@mfromanmoz
Bug 1843113 - Vendor libwebrtc from a624ee1be7
02687f4 
Upstream commit: https://webrtc.googlesource.com/src/+/a624ee1be7a11e795a849edb2a27dc1137d2b63d
    [M114] Avoid touching channel after OnSctpDataChannelClosed

    (cherry picked from commit eec1810760ccbdf95c68ed0d2c2ae10a8575551a)

    Bug: chromium:1454086
    Change-Id: I39573b706c4031d091c45a182b13cb3b2dba6233
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309920
    Reviewed-by: Harald Alvestrand <[email protected]>
    Commit-Queue: Tomas Gunnarsson <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#40332}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/310922
    Reviewed-by: Mirko Bonadei <[email protected]>
    Cr-Commit-Position: refs/branch-heads/5735@{#5}
    Cr-Branched-From: df7df199abd619e75b9f1d9a7e12fc3f3f748775-refs/heads/main@{#39949}
fabricedesre pushed a commit that referenced this issue Aug 29, 2023
@mfromanmoz
Bug 1847074 - Vendor libwebrtc from 6603550a42
6b8f918 
Upstream commit: https://webrtc.googlesource.com/src/+/6603550a4279b4b68b8b763523370dc8e010500c
    [Merge-M115] Support conversion of VP9 non-flexible mode to generic descriptor for non-layered streams only.

    When VP9 HW encoders don't provide any metadata a minimal non-flexible mode structure is generated for the stream: (https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc;l=1275-1298;drc=f80633b34538615fcb73515ad8c4bc56a748abfe).

    (cherry picked from commit 4e0bf2e5a1946b8f94f4b23b57b3e89a25fce65d)

    Bug: chromium:1455428, b/286993839, b/287458300
    Change-Id: I72628f20927d685e9c8ba1744126d763896bd804
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309380
    Commit-Queue: Philip Eliasson <[email protected]>
    Reviewed-by: Erik Språng <[email protected]>
    Reviewed-by: Henrik Boström <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#40316}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309921
    Commit-Queue: Henrik Boström <[email protected]>
    Cr-Commit-Position: refs/branch-heads/5790@{#5}
    Cr-Branched-From: 2eacbbc03a4a41ea658661225eb1c8fc07884c33-refs/heads/main@{#40122}
fabricedesre pushed a commit that referenced this issue Oct 4, 2023
@mfromanmoz
Bug 1851693 - Vendor libwebrtc from 626d408ba5
6cbc18b 
We already cherry-picked this when we vendored 8fbabf340d.

Upstream commit: https://webrtc.googlesource.com/src/+/626d408ba5d0ae5b1f6b66a7cf244a85ea66c11e
    [M116] Revert mid check in SdpOfferAnswerHandler::CreateDataChannel.

    This check was added here:
      https://webrtc-review.googlesource.com/c/src/+/300544

    When createOffer is used before createAnswer, this check would cause
    SetupDataChannelTransport_n to not be called for the remote channel.

    (cherry picked from commit 299cdc9057fb8925f1692ac8c7573f51b7872df6)

    Bug: webrtc:15258, chromium:1458937
    Change-Id: Ifdab35d1b0260ff03fef4beff13acf8090d59d8f
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/310460
    Reviewed-by: Harald Alvestrand <[email protected]>
    Commit-Queue: Tomas Gunnarsson <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#40357}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312123
    Reviewed-by: Mirko Bonadei <[email protected]>
    Cr-Commit-Position: refs/branch-heads/5845@{#5}
    Cr-Branched-From: f80cf814353d11a9f22bef5ce5e8868f2c72f0d0-refs/heads/main@{#40319}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabricedesre