-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BoxyHQ #997
Add BoxyHQ #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the most advanced one click apps that I've seen! Great job!
public/v4/apps/boxy-hq-only.yml
Outdated
image: boxyhq/jackson:$$cap_boxyhq_jackson_version | ||
restart: always | ||
ports: | ||
- 5225:5225 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not needed given the containerHttpPort
- Remove port mapping 5225:5225 - Running: npm ci && npm run validate_apps && npm run formatter
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor last round changes.
- id: $$cap_smtp_host | ||
label: SMTP Host | ||
description: The SMTP host. (https://boxyhq.com/docs/jackson/deploy/env-variables#smtp_host) | ||
defaultValue: smtp.example.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use examples as default values, move smtp.example.com
to description.
- id: $$cap_smtp_user | ||
label: SMTP User | ||
description: Username for the SMTP server. (https://boxyhq.com/docs/jackson/deploy/env-variables#smtp_user) | ||
defaultValue: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same ^
- id: $$cap_smtp_from | ||
label: SMTP From | ||
description: From address used to send mail. (https://boxyhq.com/docs/jackson/deploy/env-variables#smtp_from) | ||
defaultValue: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same ^
BoxyHQ’s suite of APIs for security and privacy helps engineering teams build and ship compliant cloud applications faster.
SAML Jackson can be used with any web application to integrate the Single Sign-On (SSO) authentication.
First of all, thank you for your contribution! 😄
Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.
☑️ Self Check before Merge
npm ci && npm run validate_apps && npm run formatter