Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BoxyHQ #997

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Add BoxyHQ #997

merged 6 commits into from
Oct 12, 2023

Conversation

Jastreb07
Copy link
Contributor

BoxyHQ’s suite of APIs for security and privacy helps engineering teams build and ship compliant cloud applications faster.

SAML Jackson can be used with any web application to integrate the Single Sign-On (SSO) authentication.

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • ☑️ I have tested the template using the method described in README.md thoroughly
  • ☑️ I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • ☑️ I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • ☑️ I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • ☑️ Icon is added as a png file to the logos directory.
  • ☑️ I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • ☑️ I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@Jastreb07 Jastreb07 changed the title Boxyhq Add Boxyhq Oct 9, 2023
@Jastreb07 Jastreb07 changed the title Add Boxyhq Add BoxyHQ Oct 9, 2023
Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the most advanced one click apps that I've seen! Great job!

image: boxyhq/jackson:$$cap_boxyhq_jackson_version
restart: always
ports:
- 5225:5225
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not needed given the containerHttpPort

Vitalij Dell added 4 commits October 11, 2023 10:13
- Remove port mapping 5225:5225
- Running: npm ci && npm run validate_apps && npm run formatter
@githubsaturn githubsaturn merged commit 6d9d0c3 into caprover:master Oct 12, 2023
1 check passed
@githubsaturn
Copy link
Collaborator

Thanks!

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor last round changes.

- id: $$cap_smtp_host
label: SMTP Host
description: The SMTP host. (https://boxyhq.com/docs/jackson/deploy/env-variables#smtp_host)
defaultValue: smtp.example.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use examples as default values, move smtp.example.com to description.

- id: $$cap_smtp_user
label: SMTP User
description: Username for the SMTP server. (https://boxyhq.com/docs/jackson/deploy/env-variables#smtp_user)
defaultValue: [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same ^

- id: $$cap_smtp_from
label: SMTP From
description: From address used to send mail. (https://boxyhq.com/docs/jackson/deploy/env-variables#smtp_from)
defaultValue: [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants