Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding databag messenger service #977

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

balzack
Copy link
Contributor

@balzack balzack commented Aug 7, 2023

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@githubsaturn
Copy link
Collaborator

Did you run npm run formatter locally and it worked?

@balzack
Copy link
Contributor Author

balzack commented Aug 8, 2023

I hadn't run the formatter, but I thought running prettier would have done it. Obviously I didn't do it correctly and shouldn't take short cuts, sorry for the previous failures. I ran it locally now and it passes.

@githubsaturn
Copy link
Collaborator

Thanks!

@githubsaturn githubsaturn merged commit f01c785 into caprover:master Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants