Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix supabase-postgresql volume #1000

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

ak4zh
Copy link
Contributor

@ak4zh ak4zh commented Oct 12, 2023

I just noticed bitnami images uses a different path /bitnami/postgresql for the postgres data and not the standard /var/lib/postgresql/data.
This fixes the bitnami based supabase-postgres app which currently has incorrect volume mapped, so anyone with the current one will loose data on container reboot.

The bug was introduced in #993

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@githubsaturn githubsaturn merged commit ad4810e into caprover:master Oct 13, 2023
1 check passed
@githubsaturn
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants