Merge pull request #1020 from capricorn86/task/999-innerhtml-parser-i…

…nterprets-in-unquoted-element-attributes-incorrectly #999@patch: Adds support for URLs in attributes that doesn't use apos…
capricorn86 · Aug 18, 2023 · 01fec13 · 01fec13
2 parents 059d382 + 3103e1f
commit 01fec13
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/happy-dom/src/xml-parser/XMLParser.ts b/packages/happy-dom/src/xml-parser/XMLParser.ts
@@ -40,7 +40,7 @@ const MARKUP_REGEXP =
  * Group 9: Attribute name when the attribute has no value (e.g. "disabled" in "<div disabled>").
  */
 const ATTRIBUTE_REGEXP =
-	/\s*([a-zA-Z0-9-_:.$@?]+) *= *([a-zA-Z0-9-_:.$@?{}]+)|\s*([a-zA-Z0-9-_:.$@?]+) *= *"([^"]*)("{0,1})|\s*([a-zA-Z0-9-_:.$@?]+) *= *'([^']*)('{0,1})|\s*([a-zA-Z0-9-_:.$@?]+)/gm;
+	/\s*([a-zA-Z0-9-_:.$@?]+) *= *([a-zA-Z0-9-_:.$@?{}/]+)|\s*([a-zA-Z0-9-_:.$@?]+) *= *"([^"]*)("{0,1})|\s*([a-zA-Z0-9-_:.$@?]+) *= *'([^']*)('{0,1})|\s*([a-zA-Z0-9-_:.$@?]+)/gm;
 
 enum MarkupReadStateEnum {
 	startOrEndTag = 'startOrEndTag',

diff --git a/packages/happy-dom/test/xml-parser/XMLParser.test.ts b/packages/happy-dom/test/xml-parser/XMLParser.test.ts
@@ -669,6 +669,14 @@ describe('XMLParser', () => {
 			);
 		});
 
+		it('Parses attributes with URL without apostrophs.', () => {
+			const root = XMLParser.parse(document, `<a href=http://www.github.com/path>Click me</a>`);
+
+			expect(new XMLSerializer().serializeToString(root)).toBe(
+				'<a href="http://www.github.com/path">Click me</a>'
+			);
+		});
+
 		it('Parses attributes with single apostrophs.', () => {
 			const root = XMLParser.parse(document, `<div key1='value1' key2='value2'>Test</div>`);