Skip to content

Commit

Permalink
Delete and update some Python 3.7-specific todo notes
Browse files Browse the repository at this point in the history
When I wrote some of these, I was wrong about the affected versions. Upgraded
them to v3.9
  • Loading branch information
LasseBlaauwbroek authored and haata committed Oct 13, 2023
1 parent b22763f commit cc08821
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions capnp/lib/capnp.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2062,7 +2062,7 @@ cdef class _DynamicCapabilityClient:
cdef public object _parent, _cached_schema

def __dealloc__(self):
# Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects
# Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects
# appropriately
self.thisptr = C_DynamicCapability.Client()

Expand Down Expand Up @@ -2233,7 +2233,7 @@ cdef class TwoPartyClient:
cdef cbool closed

def __dealloc__(self):
# Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects
# Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects
# appropriately
self.thisptr = Own[RpcSystem]()

Expand Down Expand Up @@ -2280,7 +2280,7 @@ cdef class TwoPartyServer:
cdef cbool closed

def __dealloc__(self):
# Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects
# Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects
# appropriately
self.thisptr = Own[RpcSystem]()

Expand Down Expand Up @@ -2341,7 +2341,7 @@ cdef class _AsyncIoStream:
protocol.transport.close()

def __dealloc__(self):
# Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects
# Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects
# appropriately
self.thisptr = Own[AsyncIoStream]()

Expand Down Expand Up @@ -2424,9 +2424,7 @@ cdef class DummyBaseClass:
pass

cdef class _PyAsyncIoStreamProtocol(DummyBaseClass, asyncio.BufferedProtocol):
# TODO: Temporary. Needed due to a missing __slots__ definitions in BufferedProtocol on Python 3.7.
# See https://github.com/python/cpython/issues/79575. Can be removed once Python 3.7 is unsupported.
cdef dict __dict__
cdef object _task

cdef public object transport
cdef object connected_callback
Expand Down

0 comments on commit cc08821

Please sign in to comment.