Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject pipelined calls when PlaceArgs returns an error. #303

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Reject pipelined calls when PlaceArgs returns an error. #303

merged 1 commit into from
Sep 19, 2022

Conversation

lthibault
Copy link
Collaborator

Pipelined calls were ignoring the error returned from sendMessage, which resulted in errors from PlaceArgs being ignored. The associated promises would never resolve.

@lthibault lthibault added the bug label Sep 19, 2022
@lthibault lthibault requested a review from zenhack September 19, 2022 19:36
@zenhack zenhack merged commit e6d2ca4 into main Sep 19, 2022
@lthibault lthibault deleted the bugfix/pipeline-promise branch September 19, 2022 19:39
@lthibault lthibault mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenhack zenhack zenhack approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lthibault @zenhack