Kill the struct wrapper around Client #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in generated interface types. This means that Client and the wrapper
types have the same underlying type, so we can CapList for both.
Notes:
- The pogs package has some test failures that need fixing.
- Annoyingly, we can't just use ~Client as the constraint, since the
proper underlying type is `struct { *client }`. But it works.
lthibault
previously approved these changes
Aug 1, 2022
lthibault
previously approved these changes
Aug 1, 2022
|
Fixed the tests. One thing I really don't like about this is that go doc shows the constraint as |
zenhack
changed the title
|
Forgive me if we've covered this before, but is there a reason why the constraint can't be |
|
If I use |
This lets us refer to it outside the main package, and it also means that CapList's constraint isn't exposing as much implementation detail.
|
Per discussion via matrix, I pushed another commit that makes an alias |
lthibault
previously approved these changes
Aug 1, 2022
lthibault
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in generated interface types. This means that Client and the wrapper
types have the same underlying type, so we can CapList for both.
Notes:
proper underlying type is
struct { *client }. But it works.Marking this as a draft for now.