Remove a couple uses of the *_List type aliases. #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for removing the aliases entirely. Most importantly, this patch removes the one use inside the code generator itself. We can't actually delete the aliases until the code generator no longer uses them at call sites, but this is the first step.
lthibault
approved these changes
Aug 1, 2022
|
The failure is one of our known intermittent issues, so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for removing the aliases entirely. Most
importantly, this patch removes the one use inside the code generator
itself.
We can't actually delete the aliases until the code generator no longer
uses them at call sites, but this is the first step.