Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the APIs so that everything operates on Client instead of
*Client. This will smooth over a couple things I've run into, mainly
around being able to implement interfaces where a method needs to
re-assign the receiver.
I'm open to debate as to whether this is a good change. Copying my message from matrix for posterity:
Despite the size of the diff, I don't think this will be horribly disruptive to downstream code; for ocap-md I just needed to re-run the schema compiler and it just worked. Changes should be pretty mechanical in the cases where you are working with raw
Client
s.