Move Transport into its own package, and export transport.NewPipe #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - moves the contents of transport.go (and related test files) into a new transport package, - Removes *Transport from the name of some functions, since it is now redundant with the package name. - exports the newPipe function as transport.NewPipe; it is needed by other tests in the rpc package, and probably useful in its own right anyway (outside of tests). - Adds aliases for the stuff that's been moved, for compatibility. This is the beginning of a larger effort to split up the rpc package, which is large and has somewhat vague internal abstraction boundaries.
lthibault
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
into a new transport package,
redundant with the package name.
other tests in the rpc package, and probably useful in its own right
anyway (outside of tests).
This is the beginning of a larger effort to split up the rpc package,
which is large and has somewhat vague internal abstraction boundaries.