Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter warning due to discarded CancelFunc in mpsc_test #230

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix linter warning due to discarded CancelFunc in mpsc_test #230

merged 1 commit into from
Apr 28, 2022

Conversation

lthibault
Copy link
Collaborator

My linter complains when context.CancelFunc return values (e.g. from WithTimeout) are discarded without being called. This PR fixes such an issue in TestRecvEmpty.

@lthibault lthibault requested a review from zenhack April 28, 2022 22:03
@zenhack zenhack merged commit bd319b7 into main Apr 28, 2022
@lthibault lthibault deleted the enhancement/mpsc-test-lintfix branch April 28, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenhack zenhack zenhack approved these changes

Assignees
No one assigned
Labels
cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lthibault @zenhack