Add some helpers for acquiring locks #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a couple helpers "With" and "Without", which make it easier to follow where the boundaries of critical sections (and the holes in them) are, when the helpers are applicable. This is especially helpful in that using it consistently means places where the lock management is *not* just a simple straight-line critical section stand out.
lthibault
previously approved these changes
Jan 3, 2022
|
Ah, I see the reason you didn't merge is because there were conflicts. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple helpers "With" and "Without", which make it easier
to follow where the boundaries of critical sections (and the holes in
them) are, when the helpers are applicable.
This is especially helpful in that using it consistently means places
where the lock management is not just a simple straight-line critical
section stand out.